Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator logos appear inconsistently #579

Open
michaelotis opened this issue Oct 12, 2021 · 0 comments
Open

Validator logos appear inconsistently #579

michaelotis opened this issue Oct 12, 2021 · 0 comments

Comments

@michaelotis
Copy link
Contributor

In this file,

https://github.com/harmony-one/staking-dashboard/blob/master/appengine/src/services/sync/validators-avatars.ts

logos are populated from both github and keybase. This creates an inconsistent loading experience where logos are not loaded. This has been brought up as an issue before and was closed with no response. While a small issue, it is a very large issue in the validator community when their logos sporadically load because they're using the recommended method of using keybase.

I propose to remove all github pointers and only use keybase and attempt to determine if the caching mechanism is flawed which is why logos aren't loaded properly.

@michaelotis michaelotis changed the title Validator logos appear inconsistently due to mixed Validator logos appear inconsistently Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant