Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor message actions #98

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2022

  • actions are in messages rather than in embeds
  • actions have custom info set by a bot to distinguish different actions in the same message
  • buttons do not have data attached - the action's info is used instead
  • text input can have a default value
  • document that users cannot add actions to messages, only bots
  • document that servers must verify that the user is sending somewhat valid data to the bot
  • remove ActionPayload; it is redundant, the only thing that is being sent is a bytes data for all options anyway

stable/chat/v1/messages.proto Show resolved Hide resolved
stable/chat/v1/messages.proto Show resolved Hide resolved
stable/chat/v1/messages.proto Outdated Show resolved Hide resolved
stable/chat/v1/messages.proto Outdated Show resolved Hide resolved
stable/chat/v1/messages.proto Show resolved Hide resolved
@yusdacra yusdacra changed the title refactor message actions feat: refactor message actions Apr 1, 2022
@yusdacra yusdacra merged commit cdbdf39 into chat/invite-events Apr 1, 2022
@yusdacra yusdacra deleted the spiralw/refactor/actions branch April 1, 2022 23:35
@yusdacra yusdacra restored the spiralw/refactor/actions branch April 2, 2022 01:09
@yusdacra yusdacra deleted the spiralw/refactor/actions branch April 2, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants