Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication #95

Closed
svenstaro opened this issue Jan 28, 2024 · 7 comments · Fixed by #98
Closed

Add authentication #95

svenstaro opened this issue Jan 28, 2024 · 7 comments · Fixed by #98
Labels
new feature new feature

Comments

@svenstaro
Copy link

OBS supports sending a bearer token. I think it'd be nice if that were supported by xiu for some basic authentication.

@harlanc harlanc added the new feature new feature label Jan 29, 2024
@harlanc
Copy link
Owner

harlanc commented Jan 29, 2024

What authentication methods do you usually use?

@svenstaro
Copy link
Author

I think OBS uses Bearer? To be honest, I'm not super sure which authentication they support but I think it might make sense to support the same scheme.

@mpisat
Copy link

mpisat commented Feb 4, 2024

Whip supports Bearer: HTTP header authorization. However, it would be nice if xiu supports both Bearer and auth based on a parameter such as whip?app=live&stream=test&key=whateverencryptedpasswordhere

@harlanc
Copy link
Owner

harlanc commented Feb 7, 2024

To implement the feature, some refactor work needs to be done: most of the http mod codes in RTSP and WebRTC library are duplicate, which can be extracted as a common library and then the authentication logics can be added in this library.

@harlanc
Copy link
Owner

harlanc commented Feb 10, 2024

Reference : https://pengrl.com/lal/#/auth for the auth algorithms.

@harlanc harlanc linked a pull request Feb 10, 2024 that will close this issue
@svenstaro
Copy link
Author

Thanks!

@harlanc
Copy link
Owner

harlanc commented Feb 20, 2024

https://harlanc.github.io/v0.10.0/docs/authentication/introduction Doc for Authentication Algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants