Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DroidFS PDF viewer does not display file, crashes app #303

Open
r9591 opened this issue Aug 25, 2024 · 13 comments
Open

DroidFS PDF viewer does not display file, crashes app #303

r9591 opened this issue Aug 25, 2024 · 13 comments

Comments

@r9591
Copy link

r9591 commented Aug 25, 2024

DroidFS 2.2.0 installs without issue but PDF viewer does not load file then crashes the app.

Edit: The install was interupted because it would not
upgrade on top of a previous version, so I need to uninstall the old version first. Is that correct? I'm using Android 13.

I have a log file, how do I send it to you?

I'm new on github, have used DroidFS a long time,
had to sign up here to let you know. The app is
amazing but the PDF thing was disappointing.

Thank you for the app.

@hardcore-sushi
Copy link
Owner

It would be very helpful if you can share the specific PDF file causing the crash. You can send it with your crash log here as GitHub attachments. You can encrypt them with my PGP key if they contain sensitive info.

The install was interupted because it would not upgrade on top of a previous version, so I need to uninstall the old version first.

Where did you download the previous and the new versions from?

had to sign up here to let you know

The repository is also hosted on Gitea specifically for people wanting to avoid GitHub.

@r9591
Copy link
Author

r9591 commented Aug 25, 2024

I cant remember where the previous version came from, but very probably F-droid. The recent upgrade was from here at Gihub.

I'm sending the log and pdf. The pdf is a random junk document i downloaded, from where i don't recall, to test the app.

Thanks for the speedy reply.

DroidFS_2024-08-25_04_10_51.log

NPPF_December_2023.pdf

@hardcore-sushi
Copy link
Owner

I cant remember where the previous version came from, but very probably F-droid. The recent upgrade was from here at Gihub.

Then that's expected. F-Droid builds are signed with F-Droid keys, whereas GitHub and Gitea builds are signed by me.

The app doesn't crash on my side. According to the provided logs, the app seems to have crashed when you clicked on the "Properties" menu in the PDF viewer screen. Is this correct? Or did the app crash as soon as you opened the file without any further interaction?

@r9591
Copy link
Author

r9591 commented Aug 26, 2024

Yes, Properties, because the file did not display, white screen only, so Properties then crash!

Should I go back to F-droid and try their version?

@hardcore-sushi
Copy link
Owner

OK. Could you share your logcat recorded while you open the PDF file?

You can try the F-Droid version but I think it will be the same result. What's your Android ROM? What's the version of your WebView?

@r9591
Copy link
Author

r9591 commented Aug 26, 2024

Where do I get a logcat?

I'm using a moto e13, Model number (SKU): XT2345-3,
Hardware version: PVT

Kernel:
5.4.190-android12-9-g80224059bda2-ab313

@r9591
Copy link
Author

r9591 commented Aug 26, 2024

OK, I see what you want. I'm not a developer, I don't use ADB, I can't help you with that. Sorry, I only use Github to get a message to you.

@hardcore-sushi
Copy link
Owner

DroidFS has a built-in logcat viewer in the settings. Just open the PDF file then go to this screen, click save in the top right corner and share the saved file. Otherwise you can use LogFox if you have root access.

Can you go to Developer options > WebView implementation and show your system webview version?

@r9591
Copy link
Author

r9591 commented Aug 26, 2024

I found the Webview version:

108.0.5359.128

I found the logcat, will send that to you.

@r9591
Copy link
Author

r9591 commented Aug 26, 2024

Here is the logcat

DroidFS_2024-08-26_20_13_15.log

@hardcore-sushi
Copy link
Owner

Thanks. That version is pretty old. It was released almost 2 years ago. Using a newer webview may fix the issue.

Your second logcat is unfortunately not helpful as it does not seem to include any related warnings.

@r9591
Copy link
Author

r9591 commented Aug 26, 2024

The analysis sounds good, i agree, very likely old Webview.

I have now uninstalled version 2.2.0 and replaced it with 2.1.3 from your Github until i get Webview fixed.

Everything appears to be working now so all is well.

Thank you

@hardcore-sushi
Copy link
Owner

Oh so it works with 2.1.3. As the DroidFS PDF viewer is based on the GrapheneOS one, can you try to open your file with the original PdfViewer app version 17, 18 and 19? You can download the APKs from their release page: https://github.com/GrapheneOS/PdfViewer/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants