-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume crash #302
Comments
Could you share how you fixed your issue? Thanks |
I created a new volume it moved my files to it. |
This is still strange. The app shouldn't crash, even if some files are corrupted. Could you share the problematic volume so I can investigate on my side? |
I don't if it is a corrupted files thing, because i moved the same files without any modifications to a new volume and it works perfectly. Unfortunately i can't share the volume as it contains personal data. But here are the logs from the app |
Did you create the volume with DroidFS, or with gocryptfs and then added it to the app? What about the new working volume? How did you moved the files to the new volume? Using or DroidFS cross-volume import, or otherwise? If you remove all the personal data from the buggy volume, does the crash still happen? If so, could you share the volume with the data removed? |
I honestly can't remember how i made the old volume, but the new volume was made in Droidfs. Yeah i used Droidfs to move the files between the volumes. Tried that, I removed all the files and the crash disappeared. Maybe it's an upstream issue? Because the volume was pretty old, maybe it doesn't work with new vesion of gocrypfs in Droidfs? I can share it with you if you want, just tell me how you want me to send it. |
Would you be able to determine the exact file that, once deleted, caused the crash to disappear? I don't think it's an upstream issue as you said you were able to mount it on Linux successfully.
Thanks, you can create an archive of your encrypted volume and send it to me using a private upload service like https://upload.disroot.org. You can send me the password by email encrypted with my PGP key or on Matrix. |
Never mind, i found the cause of the crash while searching for the "file" that was causing it. The reason was having too much folders inside of each other. screen-20240820-203753.mp4That i think is a bug in droidfs? I tried different setting, disabled "map folders" option disabled "thumbnails" etc, same crash. |
Thanks for your investigation. Yes it's definitely a bug in DroidFS. Unfortunately the crash doesn't happen on my side. Did you created this volume with the latest DroidFS v2.2.0? Is it using AES or XChaCha cipher? What's inside folder6? If it doesn't contain personal data, could you send me the whole volume? |
Yes i used the latest f-droid release v2.2.0, i tried AES and Xchacha, same crash and the folders were empty. On the bright side it doesn't crash on cryfs, so maybe i'll migrate? Here's the volume: |
I cannot reproduce the issue on my side, but after examining your crash log, I found a stupid error in the gocryptfs JNI code which causes invalid memory access, which is most likely the cause of the crash. I fixed it with 4aa211b. Can you build the app to test if the bug is really gone? Otherwise, I can provide you with a pre-compiled debug APK. |
Thanks for looking into the issue. I couldn't build the app because i got an error when i tried to compile ffmpeg. If you want me to test the fix, i would appreciate an apk. otherwise i can wait for the next release. |
Another bug... Could you please give me more details? What did you do and what error did you get? Here is a debug APK: https://upload.disroot.org/r/ehSyceLk#uaoS6PzHIK2uIYWqXc+bF5lA5dQRCxz38f9+53RqJ+I= |
Haha don't worry i'm probably missing a dependency or something. I followed the build.md successfully until i tried to compile ffmpeg, it gave me this error:
But your fix worked perfectly, 0 crashes. |
Great. Then the next official release should permanently fix the issue. Thanks for you bug report. Regarding the ffmpeg build, the error message seems to indicate that the file
If the output is different, you can try to run
|
The issue wasn't fixed. and i only found |
Thank you. Here is the relevant line:
There is an issue with your NDK installation. Could you check that
|
That file exists.
|
I just tried to compile it again an got this long ahhh error:
Man, if it's something wrong on my end and not your build.md, then please forget about it i don't want to bother you anymore. |
You don't bother me, don't worry. Everything looks fine. The long output is not an error. It's just a lot of compilation warnings. The build must have succeed. Check the
Did you change something to make the first error disappear? |
Thanks to you, i just built my first ever apk :)
I previously only had the command line told only because i thought they were sufficient. What i changed is that i installed the full android studio GUI. final note, for me even with
So i had to make that file and put |
Congratulations! Indeed, command line tools should be sufficient. I'll investigate this. And you are right about the |
No description provided.
The text was updated successfully, but these errors were encountered: