-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dkim_sign: default sign #2649
Merged
msimerson
merged 11 commits into
haraka:master
from
msimerson:2499-dkim-sign-default-sign
Sep 5, 2019
Merged
dkim_sign: default sign #2649
msimerson
merged 11 commits into
haraka:master
from
msimerson:2499-dkim-sign-default-sign
Sep 5, 2019
Commits on Aug 31, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 708fc66 - Browse repository at this point
Copy the full SHA 708fc66View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4afc21 - Browse repository at this point
Copy the full SHA d4afc21View commit details -
dkim_sign: refactored for testability
- rename load_dkim_key -> load_dkim_default_key - pass dkim signing properties (domain, selector, key) around as object - call get_headers_to_sign when registering (vs. every transaction) - factor get_sign_properties out of outbound hook (simpler, enables test coverage) - when a dkim/${domain} dir is found, assure selector and key load
Configuration menu - View commit details
-
Copy full SHA for 7a7286c - Browse repository at this point
Copy the full SHA 7a7286cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b388e55 - Browse repository at this point
Copy the full SHA b388e55View commit details -
Configuration menu - View commit details
-
Copy full SHA for d517f0e - Browse repository at this point
Copy the full SHA d517f0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ca5c1 - Browse repository at this point
Copy the full SHA e3ca5c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e50c092 - Browse repository at this point
Copy the full SHA e50c092View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7ef8fd - Browse repository at this point
Copy the full SHA e7ef8fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e4ea7a - Browse repository at this point
Copy the full SHA 2e4ea7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ee717d - Browse repository at this point
Copy the full SHA 5ee717dView commit details
Commits on Sep 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8a2c76c - Browse repository at this point
Copy the full SHA 8a2c76cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.