dkim_sign: default sign #2649
Merged
dkim_sign: default sign #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2649 +/- ##
=========================================
- Coverage 59.81% 59.72% -0.1%
=========================================
Files 29 29
Lines 6396 6409 +13
Branches 1588 1592 +4
=========================================
+ Hits 3826 3828 +2
- Misses 2570 2581 +11
Continue to review full report at Codecov.
|
msimerson
requested review from
analogic,
superman20,
baudehlo,
smfreegard and
a team
- rename load_dkim_key -> load_dkim_default_key
- pass dkim signing properties (domain, selector, key) around as object
- call get_headers_to_sign when registering (vs. every transaction)
- factor get_sign_properties out of outbound hook (simpler, enables test coverage)
- when a dkim/${domain} dir is found, assure selector and key load
msimerson
force-pushed
the
2499-dkim-sign-default-sign
branch
from
0f2e940
to
2e4ea7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2600
Fixes #2669
Fixes #2668
Changes proposed in this pull request:
Checklist: