conn: use is_local instead of localhost addr tests #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
======================================
Coverage 59.7% 59.7%
======================================
Files 29 29
Lines 6386 6386
Branches 1587 1587
======================================
Hits 3813 3813
Misses 2573 2573
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
======================================
Coverage 59.7% 59.7%
======================================
Files 29 29
Lines 6386 6386
Branches 1587 1587
======================================
Hits 3813 3813
Misses 2573 2573
Continue to review full report at Codecov.
|
baudehlo
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When I run a command like
haraka -c /data --qunstick example.comI get back an error telling me I'm not allowed to run INTERNALCMD remotely. Combined with haraka/haraka-net-utils#40, this fixes that by extending theis_local_ipchecks to include IPs bound to local interfaces.Related to haraka/haraka-net-utils#40
Checklist: