Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection.createConnection is not a constructor #2618

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Connection.createConnection is not a constructor #2618

merged 1 commit into from
Mar 28, 2019

Conversation

k2s
Copy link
Contributor

@k2s k2s commented Mar 28, 2019

Fixes #2617

Changes proposed in this pull request:

  • removing new keywoard

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #2618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2618   +/-   ##
=======================================
  Coverage   59.64%   59.64%           
=======================================
  Files          29       29           
  Lines        6413     6413           
  Branches     1588     1588           
=======================================
  Hits         3825     3825           
  Misses       2588     2588

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a5624...048fea6. Read the comment docs.

@baudehlo baudehlo merged commit 2233ce3 into haraka:master Mar 28, 2019
@k2s k2s deleted the patch-1 branch March 28, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants