Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for CC clock signal in ld-process-vbi #888

Open
atsampson opened this issue May 14, 2024 · 0 comments
Open

Check for CC clock signal in ld-process-vbi #888

atsampson opened this issue May 14, 2024 · 0 comments
Labels
becausetechnidisc (or other dodgy mastering issues) enhancement ld-decode-tools An issue only affecting the ld-decode-tools

Comments

@atsampson
Copy link
Collaborator

atsampson commented May 14, 2024

The closed captions on From Dusk Till Dawn (9474 AS) side 3 don't decode very well:

mpv-shot0007

The problem here is that this disc only has CC line 21 on the first field of each frame. ld-process-vbi does some basic sanity-checking, but if the top line of the active area looks enough like a CC signal - e.g. in the shot above - then it'll attempt to decode it, resulting in junk in the CC bytes.

At present we don't check that the CC clock signal is present at the start of the each line. That would be a useful improvement here - it'd filter out nearly all of the spurious lines.

(Edit: unintentional but appropriate issue number for a subtitling problem!)

@atsampson atsampson added enhancement ld-decode-tools An issue only affecting the ld-decode-tools becausetechnidisc (or other dodgy mastering issues) labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
becausetechnidisc (or other dodgy mastering issues) enhancement ld-decode-tools An issue only affecting the ld-decode-tools
Projects
None yet
Development

No branches or pull requests

1 participant