Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change emptyStatusCode to 204 by default #3919

Closed
hueniverse opened this issue Feb 2, 2019 · 3 comments
Closed

Change emptyStatusCode to 204 by default #3919

hueniverse opened this issue Feb 2, 2019 · 3 comments
Assignees
@hueniverse
Labels
breaking changes Change that can breaking existing code
Milestone
19.0.0

Comments

@hueniverse
Copy link
Contributor

No description provided.

@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Feb 2, 2019
@hueniverse hueniverse self-assigned this Feb 2, 2019
@marcuspoehls
Copy link
Contributor

I like this change!

Does hapi also detect empty response payloads and sets 204 by default?

@hueniverse
Copy link
Contributor Author

That's what this setting is all about.

@marcuspoehls
Copy link
Contributor

Nice!

I didn't know that there is already an empty response detection in place. I digged through the code and now know it. Sweet!

@hueniverse hueniverse added this to the 19.0.0 milestone Sep 14, 2019
@hueniverse hueniverse mentioned this issue Jan 10, 2020
Closed
@mfeltscher mfeltscher mentioned this issue Jan 14, 2020
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
breaking changes Change that can breaking existing code
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@hueniverse @marcuspoehls