Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node v8 #3910

Closed
hueniverse opened this issue Jan 19, 2019 · 4 comments
Closed

Drop support for node v8 #3910

hueniverse opened this issue Jan 19, 2019 · 4 comments
Assignees
Labels
breaking changes Change that can breaking existing code
Milestone

Comments

@hueniverse
Copy link
Contributor

Pave the way for new language features such as for await...of.

@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Jan 19, 2019
@hueniverse hueniverse added this to the 19.0.0 milestone Jan 19, 2019
@hueniverse hueniverse self-assigned this Jan 19, 2019
@mcollina
Copy link

Wow! This is a big change.

I would like to have Readable stream async iterator support out of experimental asap. It would be good to have your feedback on that, as it’s probably a feature that you plan to use.

@hueniverse
Copy link
Contributor Author

@mcollina point me in the right direction... happy to play with it.

@kanongil
Copy link
Contributor

With current v10, BigInt support is also included, and URL is exposed as a global (no need to require('url')).

It also allows us to use util.types for type detection in Hoek.

@mcollina
Copy link

@hueniverse nodejs/readable-stream#333. I also wrote https://github.com/mcollina/stream-iterators-utils#utilstoreadablegenerator-opts ( I'd like to get it into core at some point).

Overall the question is that:

const http = require('http')

async function handle (req, res) {
  let chunks = []
  for await (let chunk of req) {
    chunks.push(chunk)
  }
  res.end()
}

http.createServer(function (req, res) {
  handle(req, res).catch(() => res.end())
})

Is stable for the Hapi community to use. It also works on files and on any other stream from core or created via readable-stream.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code
Projects
None yet
Development

No branches or pull requests

3 participants