WindowCovering not working #56

yfre · 2019-01-22T08:29:24Z

WindowCovering was not working for me. I get the message "Could not add home" in the home app. commenting out following lines in WindowCoveringService solved the issue
/**
addCharacteristic(new HoldPositionCharacteristic(windowCovering));

	addCharacteristic(new ObstructionDetectedCharacteristic(() -> windowCovering.getObstructionDetected(),
			c -> windowCovering.subscribeObstructionDetected(c),
			() -> windowCovering.unsubscribeObstructionDetected()));

	if (windowCovering instanceof HorizontalTiltingWindowCovering) {
		addCharacteristic(new CurrentHorizontalTiltAngleCharacteristic(
				(HorizontalTiltingWindowCovering) windowCovering));
		addCharacteristic(new TargetHorizontalTiltAngleCharacteristic(
				(HorizontalTiltingWindowCovering) windowCovering));
	}
	if (windowCovering instanceof VerticalTiltingWindowCovering) {
		addCharacteristic(new CurrentVerticalTiltAngleCharacteristic(
				(VerticalTiltingWindowCovering) windowCovering));
		addCharacteristic(new TargetVerticalTiltAngleCharacteristic(
				(VerticalTiltingWindowCovering) windowCovering));
	}

*/

still unsure what is wrong with that characteristics.

The text was updated successfully, but these errors were encountered:

yfre · 2019-01-22T08:36:52Z

here the json part generated for accessories that make home app to stop to work

{
"aid": 785117798,
"services": [
{
"iid": 1,
"type": "0000003E-0000-1000-8000-0026BB765291",
"characteristics": [
{
"iid": 2,
"type": "00000023-0000-1000-8000-0026BB765291",
"perms": [
"pr"
],
"format": "string",
"events": false,
"bonjour": false,
"description": "Name of the accessory",
"value": "Arbeitszimmer Rollladen",
"maxLen": 255
},
{
"iid": 3,
"type": "00000020-0000-1000-8000-0026BB765291",
"perms": [
"pr"
],
"format": "string",
"events": false,
"bonjour": false,
"description": "The name of the manufacturer",
"value": "none",
"maxLen": 255
},
{
"iid": 4,
"type": "00000021-0000-1000-8000-0026BB765291",
"perms": [
"pr"
],
"format": "string",
"events": false,
"bonjour": false,
"description": "The name of the model",
"value": "none",
"maxLen": 255
},
{
"iid": 5,
"type": "00000030-0000-1000-8000-0026BB765291",
"perms": [
"pr"
],
"format": "string",
"events": false,
"bonjour": false,
"description": "The serial number of the accessory",
"value": "none",
"maxLen": 255
},
{
"iid": 6,
"type": "00000014-0000-1000-8000-0026BB765291",
"perms": [
"pw"
],
"format": "bool",
"events": false,
"bonjour": false,
"description": "Identifies the accessory via a physical action on the accessory"
}
]
},
{
"iid": 7,
"type": "0000008C-0000-1000-8000-0026BB765291",
"characteristics": [
{
"iid": 8,
"type": "00000023-0000-1000-8000-0026BB765291",
"perms": [
"pr"
],
"format": "string",
"events": false,
"bonjour": false,
"description": "Name of the accessory",
"value": "Arbeitszimmer Rollladen",
"maxLen": 255
},
{
"iid": 9,
"type": "0000006D-0000-1000-8000-0026BB765291",
"perms": [
"pr",
"ev"
],
"format": "int",
"events": false,
"bonjour": false,
"description": "The current position",
"value": 100,
"minValue": 0,
"maxValue": 100,
"minStep": 1,
"unit": "%"
},
{
"iid": 10,
"type": "0000006F-0000-1000-8000-0026BB765291",
"perms": [
"pw"
],
"format": "bool",
"events": false,
"bonjour": false,
"description": "Whether or not to hold position",
"value": null
},
{
"iid": 11,
"type": "00000072-0000-1000-8000-0026BB765291",
"perms": [
"pr",
"ev"
],
"format": "int",
"events": false,
"bonjour": false,
"description": "The position state",
"value": 2,
"minValue": 0,
"maxValue": 2,
"minStep": 1
},
{
"iid": 12,
"type": "0000007C-0000-1000-8000-0026BB765291",
"perms": [
"pw",
"pr",
"ev"
],
"format": "int",
"events": false,
"bonjour": false,
"description": "The target position",
"value": 100,
"minValue": 0,
"maxValue": 100,
"minStep": 1,
"unit": "%"
},
{
"iid": 13,
"type": "00000024-0000-1000-8000-0026BB765291",
"perms": [
"pr",
"ev"
],
"format": "bool",
"events": false,
"bonjour": false,
"description": "An obstruction has been detected",
"value": false
}
]
}
]
}

ghost · 2019-01-27T02:54:09Z

Same here

timcharper · 2019-01-28T03:18:55Z

I'm also observing this; when I include a MockWindowCovering in the sample app, things fail horribly. It breaks the pairing and I have to delete the pairing info and start over with the sample app. It's really a catastrophic failure, and really quite weird.

timcharper · 2019-01-28T03:30:51Z

Seems like one of the characteristics is misconfigured; I've stripped it back to the required characteristics, and it works;

timcharper@97de9aa

jrburk · 2019-02-05T12:15:23Z

Seems like one of the characteristics is misconfigured; I've stripped it back to the required characteristics, and it works;

timcharper@97de9aa

Hmm, can you post your code here. I think I have the minimal code, but the problem still exists.

yfre · 2019-02-06T10:24:23Z

Seems like one of the characteristics is misconfigured; I've stripped it back to the required characteristics, and it works;
timcharper@97de9aa

Hmm, can you post your code here. I think I have the minimal code, but the problem still exists.

in class WindowCoveringService i commented out following lines
/*
addCharacteristic(new HoldPositionCharacteristic(windowCovering));
addCharacteristic(new ObstructionDetectedCharacteristic(() -> windowCovering.getObstructionDetected(),
c -> windowCovering.subscribeObstructionDetected(c),
() -> windowCovering.unsubscribeObstructionDetected()));

if (windowCovering instanceof HorizontalTiltingWindowCovering) {
addCharacteristic(new CurrentHorizontalTiltAngleCharacteristic((HorizontalTiltingWindowCovering) windowCovering));
addCharacteristic(new TargetHorizontalTiltAngleCharacteristic((HorizontalTiltingWindowCovering) windowCovering));
}
if (windowCovering instanceof VerticalTiltingWindowCovering) {
addCharacteristic(new CurrentVerticalTiltAngleCharacteristic((VerticalTiltingWindowCovering) windowCovering));
addCharacteristic(new TargetVerticalTiltAngleCharacteristic((VerticalTiltingWindowCovering) windowCovering));
}
*/

jrburk · 2019-02-06T21:28:28Z

Thank you. Now it's working for me too...

Including HoldPositionCharacteristic causes the pairing to become corrupted, to the extend that the windowcovering accessory must be removed and the brige pairing cleared and paired anew. It isn't clear why this optional characteristic causes such spectacular failure, but it definitely does. Resolves hap-java#56

The pattern for most accessories is to require only the required characteristics, and then allow the specification of optional characteristics via the inclusion of interfaces. This pattern was not followed with WindowCovering. Worse, for reasons currently not understood, the inclusion of the HoldPositionCharacteristic causes the homekit pairing with the bridge to be completely unresponsive. (See issue hap-java#56) Change is made in a backwards compatible way, so that existing implementations that depend on WindowCovering as implemented will continue to function Addresses hap-java#56

timcharper · 2019-02-18T07:50:49Z

I've narrowed it down to HoldPositionCharacteristic, FYI

timcharper · 2019-03-09T18:29:15Z

@jrburk I still have no idea why HoldPositionCharacteristic is causing this. The latest release will use BasicWindowCovering, in the meantime.

sobeos · 2019-07-25T22:57:59Z

Any news on window coverings? I have horizontal tilting window coverings. HorizontalTiltingWindowCovering extends WindowCovering. WindowCovering is deprecated.

sobeos · 2020-01-02T00:00:52Z

I still have no idea why HoldPositionCharacteristic is causing this.

Problem is that the characteristic is write only.
Homekit complains:
"Non-readable characteristics must not contain 'value' key".
The problem is in BaseCharacteristic -> makeBuilder

sobeos · 2020-01-02T00:05:39Z

Looks like
if (isReadable) {
setJsonValue(builder, value);
}
is fixing the problem.

timcharper · 2020-01-02T22:57:34Z

Great find! Would you mind opening up a pull request?

yfre · 2020-06-10T19:48:01Z

fixed in #101

This was referenced Feb 3, 2019

Introduce BasicWindowCovering and deprecate WindowCovering #58

Merged

WindowCovering doesn't work #40

Closed

sobeos pushed a commit to sobeos/HAP-Java that referenced this issue Jan 4, 2020

Fix for WindowCovering not working hap-java#56

8410330

ccutrer closed this as completed Jun 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WindowCovering not working #56

WindowCovering not working #56

yfre commented Jan 22, 2019

yfre commented Jan 22, 2019

ghost commented Jan 27, 2019

timcharper commented Jan 28, 2019

timcharper commented Jan 28, 2019

jrburk commented Feb 5, 2019

yfre commented Feb 6, 2019 •

edited

Loading

jrburk commented Feb 6, 2019

timcharper commented Feb 18, 2019

timcharper commented Mar 9, 2019

sobeos commented Jul 25, 2019

sobeos commented Jan 2, 2020

sobeos commented Jan 2, 2020

timcharper commented Jan 2, 2020

yfre commented Jun 10, 2020

WindowCovering not working #56

WindowCovering not working #56

Comments

yfre commented Jan 22, 2019

yfre commented Jan 22, 2019

ghost commented Jan 27, 2019

timcharper commented Jan 28, 2019

timcharper commented Jan 28, 2019

jrburk commented Feb 5, 2019

yfre commented Feb 6, 2019 • edited Loading

jrburk commented Feb 6, 2019

timcharper commented Feb 18, 2019

timcharper commented Mar 9, 2019

sobeos commented Jul 25, 2019

sobeos commented Jan 2, 2020

sobeos commented Jan 2, 2020

timcharper commented Jan 2, 2020

yfre commented Jun 10, 2020

yfre commented Feb 6, 2019 •

edited

Loading