Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed FromStatfsT on Darwin to fix df output #213

Closed
wants to merge 1 commit into from

Conversation

bolshevik
Copy link

osxfuse/fuse provides a possibility to implement a standard and an extended statfs calls, the previous mapping is relevant for the statfs_x call, which is not implemented in go-fuse yet.

https://github.com/osxfuse/fuse/blob/1cd72d7333ce84975470f5d865383422034baa7d/include/fuse.h#L620
https://github.com/osxfuse/fuse/blob/abc35f85fdede186ed164082bd71fc1217d2f58f/lib/fuse.c#L4094

This change maps the Block Size to both upper-level block size and fragment size.

Previously it resulted into incorrect reporting of total and free space in the "df" command.

…incorrect reporting of total and free space in the "df" command.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@hanwen
Copy link
Owner

hanwen commented May 2, 2018

this needs a CLA.

the comments on the code you change suggest that I have actually thought about this when I wrote this, and that it wasn't a random oversight.

Could you add a test that exercises statfs on OSX that exercises this new behavior?

@hanwen hanwen closed this Dec 12, 2018
@hanwen
Copy link
Owner

hanwen commented Dec 12, 2018

no reponse for 6 months; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants