Support STL #594
Merged
Support STL #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
approved these changes
May 17, 2022
| use std::path::Path; | ||
| use std::{fs::File, path::Path}; | ||
|
|
||
| use anyhow::{anyhow, Result}; |
There was a problem hiding this comment.
Since fj-export is a library, thiserror would be a more appropriate choice here for error handling. Doesn't really matter though. Good enough for now!
Comment on lines
+91
to
+95
| [ | ||
| vector.x.into_f32(), | ||
| vector.y.into_f32(), | ||
| vector.z.into_f32(), | ||
| ] |
There was a problem hiding this comment.
This kind of code can be shortened a bit:
Suggested change
| [ | |
| vector.x.into_f32(), | |
| vector.y.into_f32(), | |
| vector.z.into_f32(), | |
| ] | |
| vector.components.map(|s| s.into_f32()) |
Not necessary, just noting the possibility.
Comment on lines
+85
to
+87
| .map(|triangle: Triangle<3>| triangle.to_parry().normal()) | ||
| .collect::<Option<Vec<_>>>() | ||
| .ok_or_else(|| anyhow!("Unable to compute normal"))?; |
There was a problem hiding this comment.
Since fj_math::Triangle is validated on construction, we could add an infallible normal method to it, which would make this kind of code simpler. Or, as a more incremental step, thanks to that validation the anyhow! here can probably be replaced with an unreachable!.
Neither of those need to happen in this pull request though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154