Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for model functions that export nothing #851

Closed
hannobraun opened this issue Jul 20, 2022 · 2 comments
Closed

Add support for model functions that export nothing #851

hannobraun opened this issue Jul 20, 2022 · 2 comments
Labels
type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

hannobraun commented Jul 20, 2022

Model functions are functions defined in a model's source code, that export an artifact. These functions are called when the model is loaded. Currently, there is only one type of model function, which exports an fj::Shape.

It should be possible to define a model function that exports nothing, and just exists for its side effects. This has no purpose within Fornjot, but given that models are written in Rust and could do basically anything, we should support this kind of flexibility. An example use case would be to export a specific file format that Fornjot itself doesn't support.

This is currently blocked on #804.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: model labels Jul 20, 2022
@hannobraun hannobraun added this to the Modeling Convenience milestone Jul 20, 2022
@hannobraun hannobraun added the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Jul 25, 2022
@hannobraun
Copy link
Owner Author

#804 has been addressed. This is no longer blocked.

@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Aug 12, 2022
@hannobraun
Copy link
Owner Author

This issue is no longer applicable. The affected code has been removed. See A New Direction for context.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant