Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noticeable delay on startup #808

Closed
hannobraun opened this issue Jul 13, 2022 · 3 comments
Closed

Noticeable delay on startup #808

hannobraun opened this issue Jul 13, 2022 · 3 comments
Labels
topic: display Displaying Fornjot models type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

Since egui support was merged (#763), I'm seeing a noticeable delay on startup. The window opens immediately, but stays transparent for some time, maybe half a second. After that, the UI and graphics are shown like normal, and I notice no other problems.

This is on an AMD Ryzen 7 5700G with Radeon Graphics (is what lshw says). Maybe it's related to #807.

@hannobraun hannobraun added type: bug Something isn't working topic: display Displaying Fornjot models labels Jul 13, 2022
@jeevcat
Copy link
Contributor

jeevcat commented Jul 14, 2022

The main delay at startup that I'm seeing is waiting for cargo build of the model to finish. Would be nice if this was somehow non-blocking.

@hannobraun
Copy link
Owner Author

The main delay at startup that I'm seeing is waiting for cargo build of the model to finish.

I haven't timed what the main delay is on my machine, but there's definitely something different since egui support was merged.

Would be nice if this was somehow non-blocking.

Yes, definitely. I think right now, all the code assumes that a model is always loaded. Would be nicer, if that were not the case. Then we could load the model asynchronously, and also support starting Fornjot without a model loaded, and then load that through in-app UI. (That second one is not important right now, I think. But it would be nice to support that, even if just as a capability that alternate Fornjot-based apps could use.)

@hannobraun
Copy link
Owner Author

I haven't seen any exceptional delays in a while, except when the model took longer to compile for some reason. That might have been the source of the delay in the first place (as @jeevcat noted), or maybe I was seeing something weird that has since cleared up (we have updated relevant dependencies multiple times since then).

I've also opened #1015 to track the specific problem of the GUI not showing before the model is loaded. Closing in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: display Displaying Fornjot models type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants