-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous Deployment build fails #369
Comments
I'll also take a peek tomorrow. Thanks for mentioning me. |
That error message a new one for me:
According to Cargo's documentation, this should work on all major operating systems:
I wonder if it has something to do with GNU vs musl 🤔 (...) I think that is the culprit, I can compile the GNU targets, but musl refuses to: $ cargo build --release --target x86_64-unknown-linux-musl
error: cannot produce cdylib for `cuboid v0.1.0 (/home/hmaus/Code/Opensource/Rust/fornjot/repo/models/cuboid)` as the target `x86_64-unknown-linux-musl` does not support these crate types Now the musl binaries, to me at least, are only a nice to have at this point. So @hannobraun we can drop them and only continue to build GNU targets for Linux. I opened a pull-request: #370 |
There could be a solution though, setting But that resulted in a ton of There is also a section on the topic in Cargo's docs: https://doc.rust-lang.org/reference/linkage.html#static-and-dynamic-c-runtimes |
Thank you for looking into this, @hendrikmaus!
I agree that they're just a nice-to-have. Dropping them for now is fine, and I think there are two alleviating factors:
I think it's probably not worth getting too deep into this. At some point, we'll switch models to WASM, most likely, which will come with a whole separate host of problems and opportunities. |
See https://github.com/hannobraun/Fornjot/actions/runs/1993939647.
This is most likely due to #368. I'll take a look tomorrow.
cc @hendrikmaus
The text was updated successfully, but these errors were encountered: