Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for GD&T #2

Closed
Bandsberg opened this issue Nov 8, 2021 · 4 comments
Closed

Feature: Support for GD&T #2

Bandsberg opened this issue Nov 8, 2021 · 4 comments
Labels
type: feature New features and improvements to existing features

Comments

@Bandsberg
Copy link
Contributor

Would you be interested in supporting GD&T?

I would love to help implementing this if it has interest. I am not an expert, but we use it (ISO GPS to be specific) in the company that I work at.

@hannobraun
Copy link
Owner

Hey @Bandsberg, thank you for your interest and for opening this issue! Yes, I'd be interested in supporting GD&T, in theory. In practice, I think we're not nearly at the point were it makes sense to seriously consider.

To explain the context, the code in the top-level directory (the one I've been working on for a while) is probably a dead end. I've just started working on a new prototype that's basically going to be a rewrite (with lots of reused code, mainly on the rendering side). It's available in the ng/ directory. Check out the README there, for more information.

So while I'd love to have support for GD&T (I just did some really bad drawings in Inkscape, and it sucked 😁), I fear that right now the technical base it would need to be built on is severely lacking.

I also think that the project hasn't reached a level of maturity yet where it could really support contributors, as long as I'm going around, creating new prototypes, deleting old code, and such. And don't get me wrong, I'd love to have help around here, and if you're interested in that, we should talk some more! But what I'm saying is, even if you submitted the perfect GD&T implementation today, I couldn't guarantee that it would still be present in the latest actively developed version a month from now.

So yeah, if you want to get involved under these circumstance, I'd love to talk about that. I'm just trying to set expectations properly. This project is really experimental, to the point where most people probably wouldn't have published it yet (I, on the other hand, know no shame when it comes to open source 😄).

@Bandsberg
Copy link
Contributor Author

@hannobraun Thank you for the good elaboration of your answer and aligning expectations! ☺️
You make some very good points.
I think for now I will follow the progress of the code and see when the time is right to contribute ☺️

P.S. Love that you are not shameful 😄

@hannobraun hannobraun added the type: feature New features and improvements to existing features label Nov 23, 2021
@hannobraun
Copy link
Owner

Since my last comment in this issue, a lot of things have changed. Since that was a broad overview of the state of the project, and parts of it are no longer true, I'd like to post an update here.

First, the prototype I was talking about has replaced the (former) main code. It's made good progress since then, and while I would still consider Fornjot to be experimental, I can see a much clearer path forward now than ever before.

Second, my statement that the project can't really support contributors is no longer true. Things have stabilized significantly since then, and I've made an effort to open actionable issues that others can pick up. (And in fact, @Bandsberg, who opened this issue, has started contributing since then.)

Third, I still think it's too early to seriously consider GD&T support. A lot of the code that such a feature would have to be built upon is still in flux, so it would either get in the way, or risk being removed again. However, this is starting to change slowly. The API that is growing in the kernel module, most relevantly in places like edges and faces is slowly evolving, and I wouldn't be surprised if my view on GD&T support were to change in a few months.

@hannobraun
Copy link
Owner

I've added this to the new Feature Wishlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants