Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render edges #16

Closed
hannobraun opened this issue Nov 26, 2021 · 1 comment
Closed

Render edges #16

hannobraun opened this issue Nov 26, 2021 · 1 comment
Labels
topic: display Displaying Fornjot models type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

Right now, only faces are rendered. And they are shaded according to their angle towards the camera.

This works very well, mostly, but if you're looking at the edge between two faces, such that both faces have exactly the same angle towards the camera, you can no longer make out the edge, and both faces look like one face.

It would be better to just render edges as a black line.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: display Displaying Fornjot models labels Nov 26, 2021
@hannobraun hannobraun added this to the Modeling convenience milestone Mar 25, 2022
@hannobraun
Copy link
Owner Author

hannobraun commented May 15, 2023

I've decided to close this issue. fj-viewer is only a development tool now, and while improvements to rendering are still in scope and very welcome, I don't think it makes sense to have too many open issues to track potential usability improvements.

See A New Direction for context.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: display Displaying Fornjot models type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant