Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log warnings and above, by default #156

Closed
hannobraun opened this issue Feb 9, 2022 · 0 comments · Fixed by #297
Closed

Only log warnings and above, by default #156

hannobraun opened this issue Feb 9, 2022 · 0 comments · Fixed by #297
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

Since I re-enabled logging recently, there's a lot of noise due to info-level logging from wgpu. I think we should only log warnings and errors by default, while still respecting whatever the user specifies via RUST_LOG. This would involve making the logger initialization in main.rs more intelligent, although I'm not completely sure what needs to be done.

Labeling https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, as this is mostly a Rust/Tracing issue that doesn't require advanced knowledge of Fornjot.

@hannobraun hannobraun added type: feature New features and improvements to existing features good first issue Good for newcomers topic: ui labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant