Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -m/--model #1272

Closed
hannobraun opened this issue Oct 26, 2022 · 2 comments · Fixed by #1323
Closed

Remove -m/--model #1272

hannobraun opened this issue Oct 26, 2022 · 2 comments · Fixed by #1323
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

fj-app can be provided with the -m/--model argument, to specify which model to load. And in fact, this is the only command-line argument that isn't really optional (strictly speaking it is, but only if a default model is specified in the configuration file).

It would be simpler to just do away with -m/--model and use a positional argument instead. So instead of this:

fj-app -m model

We'd have this:

fj-app model

I think this would be more natural. In fact, I forget the -m/--model all the time.

Labeling https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, as this only requires surface-level knowledge of Fornjot. This probably requires changes only in fj-app's args.rs.

@hannobraun hannobraun added type: feature New features and improvements to existing features good first issue Good for newcomers topic: ui labels Oct 26, 2022
@kopackiw
Copy link
Contributor

kopackiw commented Nov 7, 2022

Happy to help on that with my PR above!

Also, big thanks for very helpful documentation both in the app, as well in this issue - this is my first OSS contribution in Rust and it felt really easy to dive in! 🙇🏻

@hannobraun
Copy link
Owner Author

Thanks for taking care of this issue, @kopackiw!

Also, big thanks for very helpful documentation both in the app, as well in this issue - this is my first OSS contribution in Rust and it felt really easy to dive in! 🙇🏻

Glad to hear that! I do my best to make things easy to get into.

That doesn't always work though (limited resources and all), so if you find some code you don't understand, always feel free to open issues to request clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants