Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CD warning #1270

Closed
hannobraun opened this issue Oct 26, 2022 · 1 comment · Fixed by #1333
Closed

Fix CD warning #1270

hannobraun opened this issue Oct 26, 2022 · 1 comment · Fixed by #1333
Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

The continuous deployment build currently emits two warnings: https://github.com/hannobraun/Fornjot/actions/runs/3319079604

I believe the one about macOS is not relevant for us, but this one is:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

According to the linked blog post, this will stop working 2023-05-31.

I believe this piece of code is responsible for the warning:
https://github.com/hannobraun/Fornjot/blob/63a7518c29956c9be2bd49b36c868b41f73b2150/tools/release-operator/src/github.rs#L71-L75

Labeling https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, as this issue doesn't require any knowledge about Fornjot to address.
@hannobraun hannobraun added good first issue Good for newcomers type: development Work to ease development or maintenance, without direct effect on features or bugs topic: build Anything relating to the build system. labels Oct 26, 2022
@kopackiw
Copy link
Contributor

kopackiw commented Nov 7, 2022

Happy to work on that later today!

This was referenced Nov 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade from deprecated GH Actions set-output command kopackiw/Fornjot
2 participants
@hannobraun @kopackiw