Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graphics backend selection where Vulkan isn't preferred #10

Closed
hannobraun opened this issue Nov 22, 2021 · 3 comments
Closed

Fix graphics backend selection where Vulkan isn't preferred #10

hannobraun opened this issue Nov 22, 2021 · 3 comments
Labels
good first issue Good for newcomers topic: display Displaying Fornjot models type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

Right now, the graphics backend is hardcoded to Vulkan. I've done that for simplicity (I'm developing on Linux), then forgot all about it.
@hannobraun hannobraun added type: feature New features and improvements to existing features good first issue Good for newcomers labels Nov 22, 2021
@hannobraun
Copy link
Owner Author

In case anyone wants to take a look, the responsible code lives in graphics/renderer.rs.

@hannobraun
Copy link
Owner Author

I initially thought of this as an enhancement (as in, it works fine, it should work fine in more places), but I think it makes more sense to classify it as a bug.

@hannobraun hannobraun added type: bug Something isn't working and removed type: feature New features and improvements to existing features labels Nov 23, 2021
@hannobraun hannobraun changed the title Select appropriate graphics backend on all platforms Fix graphics backend selection where Vulkan isn't preferred Nov 23, 2021
@hannobraun hannobraun added the topic: display Displaying Fornjot models label Nov 26, 2021
@hannobraun hannobraun mentioned this issue Dec 15, 2021
Closed
@Bandsberg Bandsberg mentioned this issue Dec 16, 2021
Merged
@hannobraun
Copy link
Owner Author

Fixed by @Bandsberg in #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers topic: display Displaying Fornjot models type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannobraun