Move the model traits into their own fj::models module #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannobraun, is this closer to what you had in mind? |
hannobraun
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Thank you, @Michael-F-Bryan, much better!
One more nitpick: abi could be moved under models, and the #[doc(hidden)] could be removed. As I remarked, I have found libraries that use #[doc(hidden)] confusing to use in the past.
But that really is just a nitpick. It can be done whenever is convenient, and doesn't need to be done by you, unless you want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #885 (comment) from @hannobraun. Originally I thought he meant to move the traits into a new crate (e.g.
fj-models), but he was actually suggesting to move them out of the top-level namespace.