Replace problematic Edge
constructor with a simpler one
#627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor was problematic, because it projected the edge vertices into the curve to create the local form of the vertices, without checking whether those points lie on the curve. I also had some other concerns regarding floating point accuracy issues in the computation of these surface coordinates, but I'm not sure whether those concerns where well-founded.
In any case, the new constructors accepts the canonical and the local forms of the vertices. It doesn't verify them directly, but geometric validation will later ensure that they match.