Fix issue on my new AMD GPU #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm running into a case where this error is returned all the time, but everything still works. Constant warnings are certainly annoying, but they're better than the app not working at all.
I'm running into this issue: gfx-rs/wgpu#1218 I'm not aware of any adverse effects of switching to `PresentMode::Mailbox`, except that it's "not optimal for mobile", according to the wgpu documentation. Since we don't currently support any mobile platforms, I think this is fine for now.
|
Also works fine on my laptop. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got my new PC today, which has an AMD CPU/GPU. The old one had Intel, as does my laptop.
This pull request fixes a crash with that hardware, by logging a warning instead of panicking on a draw error. It then fixes the large number of warnings printed by switching the present mode from
PresentMode::FifotoPresentMode::Mailbox.