Coloring support #343
Coloring support #343
Conversation
therealprof
force-pushed
the
coloring-support
branch
from
62fb197 to
e882c65
Compare
There was a problem hiding this comment.
Thank you, @therealprof!
I think this looks good, overall. There are some things that could be improved, but as you state in your last commit, let's look at those later.
Some thoughts on improvements:
- There should be a
Colortype that wraps the[u8; 4]and provides a nice API around it. - I don't like how color is added to the various
fjtypes.
Regarding 2., not sure what would be better. Maybe an explicit fj::Color operation, that colors everything it wraps (might not be flexible enough, for example regarding different colors for sweep side walls, as your comment mentions).
Or maybe there could be a type Object<T> that would wrap Shape2d/Shape3d/Shape everywhere those are used, and add color information (and in the future, potentially other information that all objects share).
But that doesn't really matter right now, I'm just throwing out ideas. I'll be merging this pull request shortly.
Signed-off-by: Daniel Egger <[email protected]>
This adds access functions and fixes all users as well as README.md Signed-off-by: Daniel Egger <[email protected]>
Signed-off-by: Daniel Egger <[email protected]>
The examples have been extended to demonstrate the coloring of objects. A few bits and pieces are probably still missing or could be improved but let's look at those in another step. Closes hannobraun#291 Signed-off-by: Daniel Egger <[email protected]>
hannobraun
force-pushed
the
coloring-support
branch
from
e882c65 to
f788bdd
Compare
|
Hmm, GitHub wouldn't let me rebase, claiming there were conflicts, but doing so manually was no problem. Will merge as soon as CI is green. |
Implement basic coloring support for shapes
The examples have been extended to demonstrate the coloring of objects. A few bits and pieces are probably still missing or could be improved but let's look at those in another step.
Closes #291
Signed-off-by: Daniel Egger [email protected]