Clean up in-kernel services API #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation for simplifying services subscriptions.
Eventually, this will be needed to display history in the app. But for now, it's not being used, and it's getting in the way of other changes I'm making. It can be re-added later, as needed, and then, it'll hopefully be clearer how to better integrate it with the rest of the design.
The complexity is no longer needed, thanks to the simplified subscription model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a top-level API to
Services(which currently consists of a single method,insert_object). This enables a simplification of service subscriptions, also included in this pull request. Now, services no longer know anything about subscriptions. It is the top-levelServicesstruct that handles all that, routing objects to other services as required.The complexity that was necessary to make the previous subscription model work was getting in the way of my work on #1713, which triggered this cleanup.