Update docs for Solid
#1696
Merged
Update docs for Solid
#1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @A-Walrus! I'll take a look on Monday. |
hannobraun
requested changes
Mar 20, 2023
There was a problem hiding this comment.
Thank you for the pull request, @A-Walrus!
I've left a comment, but the only real problem is the typo, for which I've left a suggestion. I think I can probably incorporate my suggestion myself, and if so, I will merge this immediately.
If you agree with my comments, feel free to submit a follow-up pull request, if you want!
hannobraun
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion at #1694 updated the docs to make it a bit clearer.