Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused builder methods #1485

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Remove unused builder methods #1485

merged 1 commit into from
Jan 6, 2023

Conversation

hannobraun
Copy link
Owner

The unit tests that used these methods no longer exist, and as I found out, that code was very dodgy to begin with. It worked in the contexts where it was used, but it probably wouldn't have worked in real code, as it didn't correctly take care of face orientation.

Pretty sure those cubes wouldn't have made it through the 3MF validation testing.

The unit tests that used these methods no longer exist, and as I found
out, that code was very dodgy to begin with. It worked in the contexts
where it was used, but it probably wouldn't have worked in real code, as
it didn't correctly take care of face orientation.

Pretty sure those cubes wouldn't have made it through the 3MF validation
testing.
@hannobraun hannobraun enabled auto-merge January 6, 2023 15:09
@hannobraun hannobraun merged commit c20b9a6 into main Jan 6, 2023
@hannobraun hannobraun deleted the builder branch January 6, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant