Run export validation on macOS #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
force-pushed
the
export
branch
12 times, most recently
from
a35db9c to
d35ecb7
Compare
hannobraun
force-pushed
the
export
branch
4 times, most recently
from
70e497d to
d1cd751
Compare
Turns out `$ORIGIN` is Linux-specific (I think?), so it won't work on other platforms.
I don't trust the paths with '/' to hold up on Windows.
hannobraun
force-pushed
the
export
branch
4 times, most recently
from
c94f31b to
041e899
Compare
This has two advantages: - It runs export validation on more platforms, which can help catch platform-specific issues. - It saves one GitHub Actions job.
hannobraun
changed the title
This was referenced Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I failed to do the same for Windows. I just can't get it to work.
I'll open a follow-up PR, marked as draft, with my Windows code, once this is merged.