Expand validation code #1031
Merged
Expand validation code #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, wow, looks like the new curve coherence validation uncovered a bug in the existing sweep code! I wrote it to get the issues of my rewritten sweep code under control, but uncovering this bug is a nice bonus. I guess I'll have to merge the rewritten sweep code first, before I can merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on cleaning up the sweep algorithm, so I can make some progress on #993 and #1020. This work has unearthed many ways to mess up the data structures. This new validation code catches the issues I found, and should make things much easier in the future.