Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific RPCs for sendrevealall and sendredeemall to prevent human error #188

Open
tynes opened this issue May 25, 2019 · 0 comments
Open

Comments

@tynes
Copy link
Contributor

tynes commented May 25, 2019

For the wallet RPCs sendreveal and sendredeem if no name argument is passed, it will attempt to batch all of the reveals/redeems between names into a single transaction. This is a useful feature, but prone to user error if name is accidentally undefined for example.

It may be a good idea to add specific RPCs sendrevealall and sendredeemall to prevent this problem. The HTTP endpoints could be updated to reflect this as well with either additional endpoints POST /wallet/:id/revealall and POST /wallet/:id/redeemall or with POST body options.

Originally posted by @tynes in #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant