-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistencies in precompiled templates - missing sections #452
Comments
I have also tested this by saving the HTML to a file, installing handlebars globally (npm install handlebars -g) and then running |
This is a dupe of #428 which is fixed in master. I hope to roll a tagged npm release this evening to fix this issue. |
thanks kpdecker. |
hi, any update on that roll ? |
Sorry, this slipped through the cracks. I just pushed 1.0.10. Let me know if this is still failing for you. |
great news :) thank you. We are updating version now and kicking off a build, and will let you know. |
kpdecker, we have upgraded handlebars to 1.0.10 and confirm that the nested if issue is resolved (it's being used in a relatively complex handlebars template, with up to 5 levels of nested conditions in each / if / else structures). |
We have an issue when using handlebars precompilation. In the HTML code, we have snippets within handlebars operators, and some snippets just don't get included in the resulting precompiled template. The HTML has a relatively large amount of content, with lots of operators. Here's a small section of the HTML:
If I search through the precompiled template, I can't find "SEARCH FOR ME" - the comment is never included in the template. (This is happening in random places in our code, and isn't really that easy to trace). However, if we don't use precompilation and use client-side compilation, then it works fine. We precompile in node.js using a custom script as such:
var template = Handlebars.precompile(html);
template is then written to a JS file which is served to the client (which is missing the comment).
The text was updated successfully, but these errors were encountered: