From 7c896a074dad733dd60cd789b8f1cec3025d7a4a Mon Sep 17 00:00:00 2001 From: Dennis Kuczynski Date: Sun, 30 Aug 2015 10:43:24 -0400 Subject: [PATCH] Fix #each when last object entry has empty key --- lib/handlebars/helpers/each.js | 2 +- spec/builtins.js | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/handlebars/helpers/each.js b/lib/handlebars/helpers/each.js index d39a30098..9b1629b40 100644 --- a/lib/handlebars/helpers/each.js +++ b/lib/handlebars/helpers/each.js @@ -68,7 +68,7 @@ export default function(instance) { i++; } } - if (priorKey) { + if (priorKey !== undefined) { execIteration(priorKey, i - 1, true); } } diff --git a/spec/builtins.js b/spec/builtins.js index a7f6204f2..f06a1ad23 100644 --- a/spec/builtins.js +++ b/spec/builtins.js @@ -225,6 +225,16 @@ describe('builtin helpers', function() { 'each with array function argument ignores the contents when empty'); }); + it('each object when last key is an empty string', function() { + var string = '{{#each goodbyes}}{{@index}}. {{text}}! {{/each}}cruel {{world}}!'; + var hash = {goodbyes: {'a': {text: 'goodbye'}, b: {text: 'Goodbye'}, '': {text: 'GOODBYE'}}, world: 'world'}; + + var template = CompilerContext.compile(string); + var result = template(hash); + + equal(result, '0. goodbye! 1. Goodbye! 2. GOODBYE! cruel world!', 'Empty string key is not skipped'); + }); + it('data passed to helpers', function() { var string = '{{#each letters}}{{this}}{{detectDataInsideEach}}{{/each}}'; var hash = {letters: ['a', 'b', 'c']};