-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] - 'Tap' does not fire when clicked #803
Comments
@leifdejong Thank you for reporting this i will look into this. Im a little unsure on what the semantics should be here though as tap and click are different this is equivalent in some ways to expecting tap to fire if a jQuery plugin did I'm interested to hear what others think about this? @jtangelder |
Yap. Had a similar issue when binding 'tap' to an element in a UI plugin and then having a MVC* framework (in our case Backbone) bind a click on that same element, the click is never picked up. Thats why I think that the click event should always be triggered in some controlled way. This was my hack. Its ugly! var $el = $('body');
$el.on('tap click', eventHandler.bind(this));
function eventHandler(event) {
if (event.isFinal) {
action();
event.stopImmediatePropagation();
event.preventDefault();
} else {
action();
}
} Please note this solution only works on Device. Its screwy on Desktop hens looking to help find a better solution. |
@leifdejong so we have been discussing this on slack and we definitely want to try to tackle this problem as it 100% is a real problem. On jQuery mobile we have had multiple similar issues filed with our own tap event. What we are not sure is if we should fix this in hammer proper or take a more modular approach and just provide the needed hooks and develop an add on module to handle this. |
@arschmitz any way that I can be involved? I can devote some time to hacking something up. |
@leifdejong absolutely we are looking for team members see #800 and join us on slack at https://hammerjs.herokuapp.com/ Edited by @runspired to fix link |
@arschmitz this issue is another manifestation of the breakdown of It's a driving motivation behind the new approach here: runspired/ember-mobiletouch#56 Do you know if PEP handles these sorts of cases? |
this is the same thing as #808 closing in favor of that this is another tap as a fast click issue |
In Voice Over (VO) on iOS devices, 'Tap' is never fired.
Replication:
Expected:
VO does a click and somewhere, that event gets lost in Hammer. The workaround was to bind both events (click, tap) and then throw 'click' away if 'tap' is recognized. If tap is not found, it goes ahead and fires the click event.
Solution:
My recommendation for Hammer would be to bind the
click
when the 'tap' is bound and do some checks internally. This is the only way as we can know when voiceover is being used. Will be working on a fix.The text was updated successfully, but these errors were encountered: