Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

需要对现有代码作出一些改动以支持文章版本管理 #1958

Closed
guqing opened this issue Feb 16, 2022 · 5 comments
Closed

需要对现有代码作出一些改动以支持文章版本管理 #1958

guqing opened this issue Feb 16, 2022 · 5 comments
Assignees
Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.

Comments

@guqing
Copy link
Member

guqing commented Feb 16, 2022

描述

改动如下:

  1. 将预览前保存文章的接口调用改为/{postId}/status/draft/content即调用SDK为apiClient.post.updateDraftById(this.postToStage.id, this.postToStage.originalContent)
  2. SDK的BasePostSimple对象增加isInProces属性
  3. 增加对inProgress的展示,表示是否有正在编辑中的草稿
  4. 前端文章预览方法中去掉this.postToStage.status = 'DRAFT'
  5. 保存草稿按钮去掉

以上描述中有关Post的也要相应改动Sheet

Related issue: halo#1587
Related PR: halo#1617

@JohnNiang
Copy link
Member

建议:isInProcess -> wip(work in progress)

@guqing
Copy link
Member Author

guqing commented Feb 17, 2022

建议:isInProcess -> wip (work in progress)

之前想用来着但是wip是缩写应该大写WIP 而且表示boolean 所以就放弃了这个想法,isInProcess更恰当些感觉

@JohnNiang
Copy link
Member

JohnNiang commented Feb 17, 2022

这里推荐用 in-progress,而不是 is-in-processin-progress 更正式一些,像 GitLab 等都在使用 WIP(Work In Progress)。

参考:

@guqing
Copy link
Member Author

guqing commented Feb 18, 2022

@ruibaby 修改 isInProcess 属性为 inProgress

@guqing
Copy link
Member Author

guqing commented Feb 18, 2022

这里推荐用 in-progress,而不是 is-in-processin-progress 更正式一些,像 GitLab 等都在使用 WIP(Work In Progress)。

参考:

好的

@ruibaby ruibaby closed this as completed Feb 21, 2022
@JohnNiang JohnNiang transferred this issue from halo-dev/console May 6, 2022
@JohnNiang JohnNiang added the area/console Issues or PRs related to the Halo Console label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants