Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure string(REPLACE) is called with the right number of arguments #8097

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Ensure string(REPLACE) is called with the right number of arguments #8097

merged 1 commit into from
Feb 15, 2024

Conversation

alexreinking
Copy link
Member

Found while debugging macbot 3

steven-johnson
steven-johnson approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh -- thanks for the fix. I has a sad that this isn't an error.

@alexreinking alexreinking merged commit e6e1b6f into halide:main Feb 15, 2024
16 checks passed
@alexreinking alexreinking deleted the fix-string-replace branch February 15, 2024 01:58
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abadams abadams abadams approved these changes

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexreinking @steven-johnson @abadams