Add Intel APX and AVX10 target flags and LLVM attribute setting. #8052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct spelling of APX target attributes.
|
Looks like legit failures in correctness_simd_op_check_x86 |
|
They're spurious in the sense that we cannot turn on AVX10 testing while llvm is still working on it. It won't be testable for a while no matter what. |
|
Ah, so this PR won't land until LLVM is ready? |
|
Open question, but the testing will have to be disabled if it does land. It is probably useful to land it early for folks doing early development. |
|
I'd like to go ahead and land this if there are no objections. Pending passing tests, which it should now. |
|
There appear to be some TODO(resolve before landing) comments |
|
TODOs should be addressed. |
abadams
approved these changes
Feb 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened for discussion on naming. Probably can land as soon as TODOs are resolved, though LLVM support is still nascent. Likely some new intrinsics patterns can be added.