Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change startswith -> starts_with #8013

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Change startswith -> starts_with #8013

merged 1 commit into from
Jan 2, 2024

Conversation

tylerhou
Copy link
Contributor

@tylerhou tylerhou commented Jan 1, 2024 •
edited
Loading

startswith was deprecated in llvm/lvm-project#75491, which means that Halide now fails to compile using LLVM 18 (deprecation warning).

@tylerhou
Change startswith -> starts_with
657a125 
startswith was deprecated in llvm/lvm-project#75491, which means that
Halide fails to compile using LLVM 18 (deprecation warning).
@tylerhou
Copy link
Contributor Author

tylerhou commented Jan 2, 2024 •
edited
Loading

windows llvm18 build failed but I'm guessing the error is not directly related to this change:

fatal: Unable to create 'C:/build_bot/worker/halide-testbranch-main-llvm18-x86-64-windows-cmake/halide-source/.git/index.lock': File exists.
Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

I don't have permissions to rebuild, though

@steven-johnson steven-johnson self-requested a review January 2, 2024 18:27
@steven-johnson steven-johnson merged commit 6f26b04 into halide:main Jan 2, 2024
18 of 19 checks passed
@tylerhou
Copy link
Contributor Author

tylerhou commented Jan 2, 2024

Small note: it seems like starts_with was only added in LLVM 16 (added commit), so this change might break LLVM 15 builds on Windows.

ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@tylerhou @ardier
Change startswith -> starts_with (halide#8013)
2e8fee5 
startswith was deprecated in llvm/lvm-project#75491, which means that
Halide fails to compile using LLVM 18 (deprecation warning).
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerhou @steven-johnson