Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Func with a specialized with more splits than the default specialization is incorrectly assumed to be part of a compute_with group #8317

Open
abadams opened this issue Jun 24, 2024 · 0 comments
Labels

Comments

@abadams
Copy link
Member

abadams commented Jun 24, 2024

The cause is https://github.com/halide/Halide/blob/main/src/ScheduleFunctions.cpp#L1514

The sentinel value used is the number of post-split dims in the default specialization, which is not a good sentinel for the specialization definition. I'd switch to a different sentinel (e.g. -1), but you still have #8316 to deal with. I think this code should do the whole find_if dance per specialization, and not once out here. That would be in build_provide_loop_nest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant