Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The metal runtime swallows some errors #7780

Closed
abadams opened this issue Aug 18, 2023 · 4 comments
Closed

The metal runtime swallows some errors #7780

abadams opened this issue Aug 18, 2023 · 4 comments
Assignees
Labels
bug error_message Improvements to error messages

Comments

@abadams
Copy link
Member

abadams commented Aug 18, 2023

The metal runtime discovers some classes of error via the command_buffer_completed_handler, but this doesn't surface the error to, e.g. the next halide_device_sync call.

@abadams abadams added the error_message Improvements to error messages label Aug 18, 2023
@abadams
Copy link
Member Author

abadams commented Aug 18, 2023

(Discovered in #7770)

@shoaibkamil
Copy link
Contributor

@abadams abadams added the dev_meeting Topic to be discussed at the next dev meeting label Sep 6, 2023
@abadams abadams removed the dev_meeting Topic to be discussed at the next dev meeting label Sep 15, 2023
@abadams
Copy link
Member Author

abadams commented Oct 11, 2023

This can cause schedules that produce incorrect output instead of throwing an error, so I'm adding the bug tag.

@shoaibkamil
Copy link
Contributor

Fixed by #8240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error_message Improvements to error messages
Projects
None yet
Development

No branches or pull requests

2 participants