Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Overlap fixes #1545

Open
OlofSvahnVbg opened this issue Sep 2, 2024 · 2 comments
Open

Search: Overlap fixes #1545

OlofSvahnVbg opened this issue Sep 2, 2024 · 2 comments
Assignees
Labels
new feature Request for adding/changing functionality
Milestone

Comments

@OlofSvahnVbg
Copy link
Collaborator

OlofSvahnVbg commented Sep 2, 2024

There is some issue with the overlap of the search window in app:

image

As shown above, the search result window under the search bar is always displayed on top, which is not ideal when working with one or more control windows placed to the right of the screen.

This has been reported by some users as a problem.

The drawerButtons have a similiar problem when overlapping with other windows:

image

Otherwise, the control windows behave correctly when interacting with each other. The active window is put on top when clicked or interacted with, as it should.

I think this should be fixed by changing logic for search and drawerbuttons.

@OlofSvahnVbg OlofSvahnVbg self-assigned this Sep 2, 2024
@OlofSvahnVbg OlofSvahnVbg added the new feature Request for adding/changing functionality label Sep 2, 2024
@OlofSvahnVbg OlofSvahnVbg added this to the 3.x milestone Sep 2, 2024
@jacobwod
Copy link
Member

jacobwod commented Sep 2, 2024

It's good to see that this long-standing issue is being brought up.

I think that the logic must go into a few places, notably:

  • BaseWindowPlugin that controls all plugins with draggable windows
  • Search (to determine if search bar and its autocomplete should (temporarily?) overlap all draggable windows)

(There might be other cases I’ve overlooked at the moment, as I’m writing off the top of my head.)

Drawer toggle buttons should perhaps just stay "below" on all occasions. I mean: this screenshot clearly illustrates the lack of consistency:
Skärmavbild 2024-09-02 kl  11 21 56

Does this mean that a global controller is needed? I don't know. I guess we'll see how things turn out during the implementation phase.

@OlofSvahnVbg
Copy link
Collaborator Author

So I changed the issue a bit. As mentioned above I think changing logic for search and drawerbuttons is enough for now.

@OlofSvahnVbg OlofSvahnVbg changed the title Window: Overlap control/manager Search: Overlap fixes Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for adding/changing functionality
Projects
Status: Approved ideas
Development

No branches or pull requests

2 participants