Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass loop for Py3.10 compat #440

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

balloob
Copy link
Contributor

@balloob balloob commented Jun 30, 2022

This makes this package compatible with Python 3.10.

Python 3.10 removes support for the loop parameter in asyncio methods. For background on this issue, see this StackOverflow answer

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #440 (22d93f0) into master (40ce0ac) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files          42       42           
  Lines        8381     8381           
=======================================
  Hits         8092     8092           
  Misses        289      289           
Impacted Files Coverage Δ
homematicip/aio/connection.py 84.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ce0ac...22d93f0. Read the comment docs.

@balloob
Copy link
Contributor Author

balloob commented Jul 1, 2022

@coreGreenberet would you be able to take a look at this PR? It's a small one and it would help us solve an issue in Home Assistant.

@coreGreenberet coreGreenberet merged commit 1d99b89 into hahn-th:master Jul 1, 2022
@balloob balloob deleted the python-3-10-compat branch July 1, 2022 21:04
@frenck
Copy link

frenck commented Jul 5, 2022

@coreGreenberet Could you release it? So we can bump our dependencies :) Thanks! 👍

../Frenck

@coreGreenberet
Copy link
Collaborator

i wanted to do this, but the tests are not running on 3.10 for some reason. as soon as i've figured that out I will release it.

@coreGreenberet
Copy link
Collaborator

I'm skipping the 3.10 tests for now and I've deployed it with 3.9.
the new images on circleci are a little bit confusing.

@frenck
Copy link

frenck commented Jul 6, 2022

Thanks, @coreGreenberet! I've opened up a PR on the Home Assistant end to bump it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants