Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Device Support HMIP-DRDI3 #405

Merged
merged 13 commits into from
Apr 14, 2021
Merged

Conversation

mayrd
Copy link
Contributor

@mayrd mayrd commented Apr 12, 2021

  • Added Channels, DeviceTypes in base
  • Added support in hmip_cli.py (support of channelIndex for dimming and allow switch state)
  • Minor edits to .gitignore and setup.py

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #405 (05c1156) into master (c754d37) will increase coverage by 0.00%.
The diff coverage is 97.95%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   96.51%   96.52%           
=======================================
  Files          42       42           
  Lines        8267     8315   +48     
=======================================
+ Hits         7979     8026   +47     
- Misses        288      289    +1     
Impacted Files Coverage Δ
homematicip/class_maps.py 100.00% <ø> (ø)
homematicip/device.py 98.40% <94.11%> (-0.07%) ⬇️
homematicip/base/enums.py 100.00% <100.00%> (ø)
homematicip/base/functionalChannels.py 98.83% <100.00%> (+0.02%) ⬆️
homematicip/base/helpers.py 91.30% <100.00%> (+0.82%) ⬆️
tests/test_devices.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c754d37...05c1156. Read the comment docs.

homematicip/device.py Outdated Show resolved Hide resolved
homematicip/device.py Outdated Show resolved Hide resolved
@@ -1423,7 +1423,7 @@ def from_json(self, js):
super().from_json(js)
channels = get_functional_channels("MULTI_MODE_INPUT_DIMMER_CHANNEL", js)
if channels:
self.c1dimLevel = channels[1]["dimLevel"]
self.c1dimLevel = channels[0]["dimLevel"]
Copy link
Collaborator

@coreGreenberet coreGreenberet Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use self.set_attr_from_dict, that way you won't even need to implement __str__

@coreGreenberet coreGreenberet merged commit c1177e4 into hahn-th:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants