-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Device Support HMIP-DRDI3 #405
Conversation
mayrd
commented
Apr 12, 2021
- Added Channels, DeviceTypes in base
- Added support in hmip_cli.py (support of channelIndex for dimming and allow switch state)
- Minor edits to .gitignore and setup.py
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 96.51% 96.52%
=======================================
Files 42 42
Lines 8267 8315 +48
=======================================
+ Hits 7979 8026 +47
- Misses 288 289 +1
Continue to review full report at Codecov.
|
@@ -1423,7 +1423,7 @@ def from_json(self, js): | |||
super().from_json(js) | |||
channels = get_functional_channels("MULTI_MODE_INPUT_DIMMER_CHANNEL", js) | |||
if channels: | |||
self.c1dimLevel = channels[1]["dimLevel"] | |||
self.c1dimLevel = channels[0]["dimLevel"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could use self.set_attr_from_dict, that way you won't even need to implement __str__