Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Background transparency don't change when activate hop to move to word #92

Closed
jordisantamaria opened this issue Jun 12, 2021 · 8 comments · Fixed by #97
Closed

Background transparency don't change when activate hop to move to word #92

jordisantamaria opened this issue Jun 12, 2021 · 8 comments · Fixed by #97

Comments

@jordisantamaria
Copy link

Before, when I activate hop to jump to a word or a letter, code change transparency, so It was easier to see where to jump, right now background keeps the same and text is white, so It becomes harder to jump... and If code is white also... It becomes even harder...

https://gyazo.com/78f82192967d6ff7f835e1a0f0eeaee6

Is It possible to have It working as before?

@mirsella
Copy link

I got the same problem, i don't know if it's intentional, but now the shortcut are not highlighted like before.

@mirsella
Copy link

mirsella commented Jun 14, 2021

i've tracked down the commit and 7eefd95 is responsible

in my case, e5eb06d work but everything after doesn't work, and the one right after the last known working is 7eefd95

@jordisantamaria in the meantime if you use plug as a plugin manager you can use this line Plug 'phaazon/hop.nvim', { 'commit': 'e5eb06d6f3caff15f3abd35c6c21135f93fa4eb7' } to use the last working commit

@jordisantamaria
Copy link
Author

i've tracked down the commit and 7eefd95 is responsible

in my case, e5eb06d work but everything after doesn't work, and the one right after the last known working is 7eefd95

@jordisantamaria in the meantime if you use plug as a plugin manager you can use this line Plug 'phaazon/hop.nvim', { 'commit': 'e5eb06d6f3caff15f3abd35c6c21135f93fa4eb7' } to use the last working commit

I see, thanks you.

@snezhniylis
Copy link
Contributor

7eefd95 makes it a requirement to call hop.setup by moving highlight injecting code inside this function. If it's intentional, this should be documented. Also

if opts.create_hl_autocmd then  
  highlight.create_autocmd()
end

should check for M.opts instead of opts.

For now, to make it work. Put the following in your config:

require('hop').setup({create_hl_autocmd = true})

@hadronized
Copy link
Owner

create_hl_autocmd is set by default, but yes, you need to at least call setup now.

@mirsella
Copy link

is there a way to call setup in init.vim instead of init.lua ?

@ggandor
Copy link

ggandor commented Jun 20, 2021

is there a way to call setup in init.vim instead of init.lua ?

Yes, just wrap the call like this:

lua << EOF
  ...
EOF

See :h :lua-heredoc.

@snezhniylis
Copy link
Contributor

create_hl_autocmd is set by default

It is, but setup looks up create_hl_autocmd in opts which is passed as an argument, and not M.opts where it is set. This causes highlight.create_autocmd() to never get called if create_hl_autocmd is not set directly. I'll PR a fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants