Optimize foreach performance #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hadashia/vcontainer/4nY43pjJV8NBzFzxBEwMjtRoM3dD |
hadashiA
force-pushed
the
ku/optimize-foreach
branch
from
595be2d
to
b8cf4b8
Compare
hadashiA
force-pushed
the
ku/optimize-foreach
branch
from
b8cf4b8
to
539159d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array<>andList<>foreach will be expanded into allocation-free code at compile time.However, Interfaces such as
Ilist<>andIReadOnlyList<>don't seem to do so. It seems that allocations occur because they go through the IEnumerator.I preferred
IReadOnlyList<>, but found that changing foreach to a for statement reduced the allocation.Refs:
https://levelup.gitconnected.com/ilist-t-vs-list-t-performance-dad1688a374f
An example of container build test case
Before
After