Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special treatment of trait methods in bundling for fstar #1078

Closed
maximebuyse opened this issue Oct 30, 2024 · 3 comments
Closed

Remove special treatment of trait methods in bundling for fstar #1078

maximebuyse opened this issue Oct 30, 2024 · 3 comments
Labels
engine Issue in the engine f* F* backend

Comments

@maximebuyse
Copy link
Contributor

When possible, the special treatment for the fstar backend implemented in #1075 (see the discussion in the PR for the reason) should be removed. It is a hack to allow type class methods to be accessible in the original modules and not only in the bundle. But it is specific to the use we have for type classes for the translation of traits.

@franziskuskiefer
Copy link
Member

@W95Psp how is this related to #412 ?

@W95Psp
Copy link
Collaborator

W95Psp commented Nov 26, 2024

Fixing #412 will indeed fix this issue as well, thanks Franziskus!

The special treatment Maxime talks about is related to the fact F* creates a top level function per type class method in the module the type class is defined in. So this will indeed go away as soon we stop replying on F* typeclasses.

@franziskuskiefer
Copy link
Member

Ok, closing this as duplicate of #412 then. It doesn't sound like we will treat this issue separately.

@franziskuskiefer franziskuskiefer closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issue in the engine f* F* backend
Projects
None yet
Development

No branches or pull requests

3 participants