From ac6aea586e96c503b1c0a9a172c2b339c6af6053 Mon Sep 17 00:00:00 2001 From: Ben Price Date: Mon, 24 Jul 2023 13:45:14 +0100 Subject: [PATCH] fixup! todo/review notes --- primer/test/Tests/EvalFull.hs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/primer/test/Tests/EvalFull.hs b/primer/test/Tests/EvalFull.hs index a87f47ef2..820e21ab0 100644 --- a/primer/test/Tests/EvalFull.hs +++ b/primer/test/Tests/EvalFull.hs @@ -1393,12 +1393,14 @@ unit_prim_partial_map = in do s <- evalFullTestExactSteps maxID builtinTypes (gs <> prims) 91 Syn e s ~== r + -- TODO/REVIEW: -- I NEED TO WRITE A [note] about this! -- note that ww/map is somewhat pointless when push down lets -- maybe we should push lets inside letrecs (maybe just inside type?)? --- nb, get something like @let α=Char, β=Char, f=toUpper in (letrec go : List α -> List β; go = λxs.RHS in go) +-- note that ww/map is somewhat pointless when push down lets -- maybe we should push lets inside letrecs (maybe just inside type?)? +-- nb, get something like @let α=Char, β=Char, f=toUpper in (letrec go : List α -> List β; go = λxs.RHS in go)@ -- and then in two steps (expand @go@, push stack of let+letrec) --- @λxs. let α=Char, β=Char, f=toUpper in (letrec go : List α -> List β; go = λxs.RHS in RHS : List α -> List β) +-- @λxs. let α=Char, β=Char, f=toUpper in (letrec go : List α -> List β; go = λxs.RHS in RHS : List α -> List β)@ -- we carry around the subst for α,β and f, using α,β inside annotation and f in RHS each time expand the letrec -- Test that handleEvalFullRequest will reduce imported terms